dumre0707 / googlepersonfinder

Automatically exported from code.google.com/p/googlepersonfinder
Apache License 2.0
0 stars 0 forks source link

Error on RSS feed: "HTTPS is required." #103

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Steps to reproduce the issue:
- Create a person record
- Click RSS feed icon on the person record page

Expected:
The feed is shown.

Actual:
Error message "HTTPS is required." is shown.

Comment:
Should we allow showing the feed in HTTP? Or should we link to https URL and 
somehow make HTTPS version work? In google.org/personfinder, when I just modify 
the URL to https:// , it shows "Missing or invalid authorization key".

I'm happy to implement a fix if the above point is clear.

Original issue reported on code.google.com by ichik...@google.com on 18 Jul 2012 at 2:57

GoogleCodeExporter commented 9 years ago
Feed requests may contain auth keys, so I guess we want to keep https_required 
true.

Do you think it makes sense not to require an auth key for feeds/note request 
if person_record_id is specified (i.e. request for notes of a specific person)?

Original comment by r...@google.com on 18 Jul 2012 at 9:35

GoogleCodeExporter commented 9 years ago
Good catch.  We already allow subscription by e-mail to a specific person 
record, so I think it's reasonable to allow a Note feed for a specific person 
record also, using HTTP without an auth key.  The page 
http://code.google.com/p/googlepersonfinder/wiki/DataAPI would need to be 
updated to explain that no key is needed in this case.

Original comment by kpy@google.com on 18 Jul 2012 at 6:20

GoogleCodeExporter commented 9 years ago

Original comment by r...@google.com on 18 Jul 2012 at 8:56

GoogleCodeExporter commented 9 years ago
Thanks for the reply. I'll make a change to do what Ryo suggested.

Original comment by ichik...@google.com on 19 Jul 2012 at 12:18

GoogleCodeExporter commented 9 years ago
Thanks for working on it =)
Pointer: that's Note handler in app/feeds.py you'll need to change.

Original comment by r...@google.com on 19 Jul 2012 at 12:28

GoogleCodeExporter commented 9 years ago
Created CL: http://codereview.appspot.com/6445044

Original comment by ichik...@google.com on 25 Jul 2012 at 7:00

GoogleCodeExporter commented 9 years ago

Original comment by r...@google.com on 4 Aug 2012 at 3:45