When a note is marked/unmarked as spam, update its source_date so the update is visible in the outgoing feed

[GoogleCodeExporter]

Notes marked as spam should probably be emitted as empty in the outgoing note 
feed.

Original issue reported on code.google.com by kpy@google.com on 23 May 2011 at 8:30

[GoogleCodeExporter]

Original comment by ali...@google.com on 21 Sep 2011 at 9:24

• Added labels: ghc-codethon

[GoogleCodeExporter]

Original comment by ali...@google.com on 6 Oct 2011 at 6:28

[GoogleCodeExporter]

Documentation to read to understand the API:
  PFIF format: http://zesty.ca/pfif/
  The Downloading data section of http://code.google.com/p/googlepersonfinder/wiki/DataAPI
  DataModel: http://code.google.com/p/googlepersonfinder/wiki/DataModel 

How to Reproduce the bug:
in http://japan.ghc-dev.appspot.com/?lang=en
1) Create a record for a missing person and create a note about that person
2) See that you can see this person in the person feed and in the note feed 
through 
https://japan.ghc-dev.appspot.com/feeds/person?skip=0&min_entry_date=2011-11-11T
10:00:00Z&max_results=200
or
https://japan.ghc-dev.appspot.com/feeds/note?skip=0&min_entry_date=2011-11-11T10
:00:00Z&max_results=200
3) Mark the note you initially created as spam using the report spam button on 
the details page
4) Go back to the feed and see that this note is still in the note feed.

Once reported as spam, a note should be marked empty in the feed. We do not 
want to remove it from the feed, we want to keep it blank. The reason is that 
if someone already got the note feed when the note was not marked as spam, it 
might want to know that this note was changed. 

Another way to describe the bug: 

When requesting the Node Feed:
 - If note has been marked as spam, we are not propagating that information to the feed. In current implementation, we do not show spam notes in feeds. Which means if someone get the note before it is marked as spam, it will never know it was marked as spam.
 - if note has been unmarked from spam, we are not propagating that information to the feed. This means, if a note is created, then marked at spam at time T. If user get the feed at time T+1, it will not get that note. Then if this note is unmarked from spam at time T+2, then user get the feed with min_entry_date=T+1, it will never get this note.

Suggested fix:
  - when "hidden" field of a note is changed, make sure to update source_date and entry_date.
  - In note feed, if note is marked as hidden,  publish it as blank (to overwrite) instead of not publishing it
  - code change in app/model.py and app/feeds.py
  - Make sure the original_creation_date is not changed.
  - make sure to update unit_tests and server_tests

Original comment by ali...@google.com on 12 Nov 2011 at 7:04

[GoogleCodeExporter]

Fix merged to default in changeset 3ab76aa42678.

Original comment by kpy@google.com on 25 Apr 2012 at 5:28

• Changed state: done