dunbar12138 / DSNeRF

Code release for DS-NeRF (Depth-supervised Neural Radiance Fields)
https://www.cs.cmu.edu/~dsnerf/
MIT License
746 stars 126 forks source link

Question about ray distance t and depth D #70

Closed xiechun-tsukuba closed 1 year ago

xiechun-tsukuba commented 1 year ago

Hi,

Thank you for the great work.

If my understanding is correct, the depth D of a 3D point is its Z value in a camera's local coordinate system. It is different from the ray distance t, which is the distance from the point to the camera center. In fact, D = sin(θ) × t, where θ is the angle between the camera plane and the ray. Therefore, even in an ideal case, the distribution of h(t) and D are not expected to be the same.

However, in section 3.2, I see you minimizing the KL divergence between these two distributions. Wouldn't that cause some problems? Or did I miss something?

I am new to nerf, please forgive me if the answer is trivial.

Thank you

dunbar12138 commented 1 year ago

Please check the issue here #29

xiechun-tsukuba commented 1 year ago

Thank you!