search

duncan-r / SHIP

Simple Hydraulic model Interface for Python
MIT License
7 stars 6 forks source link

Remove Qt and unused funcs from filetools #10

Closed JamesRamm closed 7 years ago

JamesRamm commented 7 years ago

Fixes #9

I have not removed the qtclasses.py file which this change obsoletes as it may be used by 3rd party(?). Can remove it also if needed though...

duncan-r commented 7 years ago

It's always a tricky decision this stuff isn't it? I think if we're chucking out the Qt stuff it should probably all just go. I expect most people role their own versions of this kind of thing? I imagine the majority of people would only need Qt when working with Qgis and you would use the native dialogs rather than these for that anyway. Maybe update this with a deletion of qtclasses.py. If that's ok?

JamesRamm commented 7 years ago

@duncan-r yup sure, done.

duncan-r commented 7 years ago

Thanks, I'm going to squash these together if that's ok with you?