search

duncan-r / SHIP

Simple Hydraulic model Interface for Python
MIT License
7 stars 6 forks source link

Pep8 #3

Closed JamesRamm closed 7 years ago

JamesRamm commented 7 years ago

These are the auto fixes only for readability. The output report indicated the vast majority of fixes are related to whitespace (trimming trailing whitespace, correcting whitespace between variables/assignments etc), plus 1 or 2 long lines. The exact command run was:

autopep8 -i -r --max-line-length 150 -v ship/ and autopep8 -i -r --max-line-length 150 -v tests/

In the next PR I will add the more manual readability changes, plus a basic pylint configuration file (so we can run pylint ship/ to get a report and editors with integrations can do highlighting etc)

duncan-r commented 7 years ago

Thanks for this. I've finished the work that I was doing in the fmp package and pushed it up to dev, which is what is causing the conflicts. I'm going to pull your branches down, have a look and get them merged in for you.

As it seems all the conflicts are going to be caused by autopep8 on the above files I'll probably just keep my versions and run the tool again after the merge.

Yes it would be good to get some automated stuff set up. It's another thing that's been on my list for a while. I will try and get Travis configured on the repo so we can get eveything automated on this end. I can also include some integration tests that I have locally as well (they're a bit of an effort to maintain, but they do tend to pick up some high level reading-writing problems, so probably worth while).