search

duncan3dc / meta-audio

A PHP library to read and write metadata tags to audio files (MP3, ID3, APE, etc)
Apache License 2.0
36 stars 8 forks source link

Update Id3v2.php #19

Open za-ek opened 2 years ago

za-ek commented 2 years ago

utf8_encode corrupts cp1251 strings

duncan3dc commented 2 years ago

Hi @za-ek, thanks for your PR but I'm afraid this breaks the functionality of the library (if you run the unit tests you'll see Id3v2Test::testUtf16WithoutBom fails).

Please can you provide a unit test demonstrating the issue you're experiencing, then we can find the best way to fix it without introducing any regressions

za-ek commented 2 years ago

ah sorry I didn't see there is a test folder. Do you mean I make a PR with a test?

duncan3dc commented 2 years ago

Do you mean I make a PR with a test?

You can just push it to this PR, or if you're struggling with a test just any script/snippet I can use to reproduce the problem you're trying to fix

za-ek commented 2 years ago

I add mp3 file and test so now you can reproduce the problem

za-ek commented 2 years ago

btw you can add this line after line 166 in Id3v2.php file to fix test you mentioned:

$value = Bom::removeBom($value);