search

duncanbeevers / rails_view_annotator

Wraps the rendering of Rails partials with html comments indicating the disk location of the rendered partial
32 stars 9 forks source link

rails version support #15

Open neohunter opened 9 years ago

neohunter commented 9 years ago

I've tried this with rails 1.8.7 and raise this error

require 'rails_view_annotator' NameError: uninitialized constant ActionView::PartialRenderer

neohunter commented 9 years ago

If it's not compatible can you kindle add to the readme the versions which it will work?

patbl commented 4 years ago

It's not compatible with Rails 6.0, either. In 6.0, find_partial requires two arguments. But Rails View Annotator calls it with no arguments:

https://github.com/duncanbeevers/rails_view_annotator/blob/5e56b201db20d99fc3fac529dc750e1a157aa05c/lib/rails_view_annotator/action_view/partial_renderer.rb#L42

patbl commented 4 years ago

A co-worker of mine came up with a fix for Rails 6.0.