search

duncanmcclean / simple-commerce

A simple, yet powerful e-commerce addon for Statamic.
https://statamic.com/addons/duncanmcclean/simple-commerce
Other
145 stars 38 forks source link

Add cart tag to get tax split by tax rate. #759

Closed Sm1lEE closed 1 year ago

Sm1lEE commented 1 year ago

Depending on local rights, the order taxes have to be shown split by tax rate, e. g. 7% -> 4,55€: 19% -> 15,21€. The new tag allows just this, and comes with a variant to get also the raw values.

Also the documentation includes the new tag.

Sm1lEE commented 1 year ago

Here is an example screenshot showing the standard tax and the split tax and split tax raw:

image
Sm1lEE commented 1 year ago

Sure, I will do.

Sm1lEE commented 1 year ago

Hi @duncanmcclean, I've added a test case for the new tag.

The test case is fairly long compared to the other ones, but I did not know how to write the logic for creating tax rates, categories, products, carts... in any other way.

I'm all new to the testing-game, so if something is wrong, please let me know.

duncanmcclean commented 1 year ago

I've had a brief look and it seems good! I'll give this PR a proper review later in the week/at the weekend.

Thanks!

github-actions[bot] commented 1 year ago

Released as part of v4.2.3.