duncanmcclean / simple-commerce

A simple, yet powerful e-commerce addon for Statamic.
https://statamic.com/addons/duncanmcclean/simple-commerce
Other
147 stars 41 forks source link

Got error with Dummy Gateway #853

Closed yaser2490 closed 1 year ago

yaser2490 commented 1 year ago

Description

Hi i got error with Dummy Gateway after click on finish and pay !

Screenshot 2023-03-14 142417

Steps to reproduce

fresh install

Environment

Environment Application Name: Statamic Laravel Version: 9.52.4 PHP Version: 8.1.12 Composer Version: 2.5.1 Environment: local Debug Mode: ENABLED URL: StataBit.test Maintenance Mode: OFF

Cache Config: NOT CACHED Events: NOT CACHED Routes: NOT CACHED Views: CACHED

Drivers Broadcasting: log Cache: statamic Database: mysql Logs: stack / single Mail: smtp Queue: sync Session: file

Simple Commerce Currencies: GBP Gateways: Dummy Repository: Customer: DoubleThreeDigital\SimpleCommerce\Customers\EntryCustomerRepository Repository: Order: DoubleThreeDigital\SimpleCommerce\Orders\EntryOrderRepository Repository: Product: DoubleThreeDigital\SimpleCommerce\Products\EntryProductRepository Shipping Methods: Standard Post Tax Engine: DoubleThreeDigital\SimpleCommerce\Tax\BasicTaxEngine

Statamic Addons: 1 Antlers: runtime Stache Watcher: Enabled Static Caching: Disabled Version: 3.4.5 PRO

Statamic Addons doublethreedigital/simple-commerce: 4.5.8

duncanmcclean commented 1 year ago

Hello!

I think this might have been a bug in the Starter Kit. If you either create a new site using the starter kit OR copy the changes from this commit into your site, it should hopefully resolve the problem for you.

yaser2490 commented 1 year ago

Thanks, the error is solved.

sdussaut commented 9 months ago

Hello! I installed Simple Commerce (5.9.1) today (15/01/24) using the starter kit and the error is still there unfortunately. It seems the else close pointed out in the commit is not present in the code. By using it, it fixed the problem.

duncanmcclean commented 9 months ago

Hello! I installed Simple Commerce (5.9.1) today (15/01/24) using the starter kit and the error is still there unfortunately. It seems the else close pointed out in the commit is not present in the code. By using it, it fixed the problem.

Thanks for pointing that out, it must have been unintentionally removed at some point. I'll get it fixed.