duncanmcclean
commented
1 year ago Simple Commerce looks for a product_variants field in your blueprint - if it finds one, it assumes it's a variant product. Otherwise, it'll expect a 'Price' field to exist on the blueprint.
The workaround for now (which is the way it's done in the starter kit) is to use two different product blueprints if you need ones with variants & ones without variants.
Although, I might be able to change it to just not save those empty arrays which might fix your issue. I'd need to do some testing.
simonfrost
github-actions[bot]
Description
Hi there.
We have ~200 products, of which around 150 are only available in the bricks and mortar store (we've hidden the 'Add to Cart' button based on a flag. Of the others, around 25 have product variants, and 25 do not.
Our product blueprint has the Product Variants fieldset on a tab called Product Options as per your documentation.
On our purchasable products that DO have variants, everything seems to be in order. We can see the options, validation requires us to choose one, and we can successfully add to cart.
On our purchasable products that DO NOT have variants however, we STILL see the dropdown, but there are no options displayed.
Nothing can be selected, so we get the 'Please select an item in the list' when hitting Add to Cart.
If we temporarily hide the select box loop from the view, we can then submit, but get an error on the cart end, saying:
DoubleThreeDigital\SimpleCommerce\Products\Product::variant(): Argument #1 ($optionKey) must be of type string, null given, called in /Users/simonfrost/Sites/sound_org/vendor/doublethreedigital/simple-commerce/src/Http/Controllers/CartItemController.php on line 114
We discovered that even if a product has no variants, whenever it is saved (or a new one created) there is an empty array saved in the product_name.md file.
If we manually remove this entry (lines 73-75 in the example) and save, the options dropdown now correctly doesn't show (as there are no variants), and we can add the non variant product to our cart.
The problem we have is that any newly added products, or edited products ALWAYS seem to get this blank array written back to them, and this prevents us adding products without variants to the cart.
Maybe we're not understanding the functionality. Maybe once you have added product variants fieldset to the products blueprint, ALL products need at least one variant. Seems unlikely though. I hope I've explained the issue we're having satisfactorily, and you can offer some kind of solution!
Fabulous add-on btw. We're about to launch and purchase :-)
Steps to reproduce
Please see above.
Environment
Laravel Version: 9.33.0 PHP Version: 8.1.21 Composer Version: 2.4.2 Statamic Addons: 3 Antlers: runtime Stache Watcher: Enabled Static Caching: Disabled Version: 3.4.7 PRO
Statamic Addons doublethreedigital/simple-commerce: 4.5.8 jezzdk/statamic-google-maps: 1.2.2 rias/statamic-data-import: 1.2.2