search

duncs / clusterssh

Cluster SSH - Cluster Admin Via SSH
https://github.com/duncs/clusterssh/wiki
896 stars 79 forks source link

t/perltidy.t fails #101

Closed eserte closed 6 years ago

eserte commented 6 years ago

With App-ClusterSSH-4.12 I see:

# The file 'lib/App/ClusterSSH.pm' is not tidy
# +-----+------------------------------------------------------------------------------+------------------------------------------------------------------------------+
# | 1452|            );                                                                |            );                                                                |
# | 1453|                                                                              |                                                                              |
# | 1454|            # See if there are any commands in the external command pipe      |            # See if there are any commands in the external command pipe      |
# * 1455|            if( defined $self->{external_command_pipe_fh} ) {                 |            if ( defined $self->{external_command_pipe_fh} ) {                *
# | 1456|                my $ext_cmd;                                                  |                my $ext_cmd;                                                  |
# | 1457|                sysread( $self->{external_command_pipe_fh}, $ext_cmd, 400 );  |                sysread( $self->{external_command_pipe_fh}, $ext_cmd, 400 );  |
# | 1458|                if ($ext_cmd) {                                               |                if ($ext_cmd) {                                               |
# +-----+------------------------------------------------------------------------------+------------------------------------------------------------------------------+

#   Failed test ''lib/App/ClusterSSH.pm''
#   at t/perltidy.t line 13.
# Looks like you failed 1 test of 27.
t/perltidy.t ...... 
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/27 subtests

tidy-related versions:

    Perl::Tidy          20171214 20171214
    Test::PerlTidy      0        20130104
duncs commented 6 years ago

Thanks for the report - this is already fixed in the repo - I'll put out a new release for this shortly