duncs / clusterssh

Cluster SSH - Cluster Admin Via SSH
https://github.com/duncs/clusterssh/wiki
896 stars 79 forks source link

4.14 fails to update from 4.13 on CentOS 7 #102

Closed TheFiZi closed 4 years ago

TheFiZi commented 6 years ago
me@localhost:~$ cpan update App::ClusterSSH

Loading internal null logger. Install Log::Log4perl for logging messages
Reading '/home/me/.cpan/Metadata'
  Database was generated on Wed, 03 Jan 2018 01:53:56 GMT
Running install for module 'App::ClusterSSH'
Checksum for /home/me/.cpan/sources/authors/id/D/DU/DUNCS/App-ClusterSSH-4.13.tar.gz ok
Configuring D/DU/DUNCS/App-ClusterSSH-4.13.tar.gz with Build.PL
Created MYMETA.yml and MYMETA.json
Creating new 'Build' script for 'App-ClusterSSH' version '4.13'
  DUNCS/App-ClusterSSH-4.13.tar.gz
  /usr/bin/perl Build.PL -- OK
Running Build for D/DU/DUNCS/App-ClusterSSH-4.13.tar.gz
Building App-ClusterSSH
Using perl binary: /usr/bin/perl
Using perl version v5.16.3
Generating: ccon
Generating: clusterssh_bash_completion.dist
Generating: crsh
Generating: csftp
Generating: cssh
Generating: ctel
  DUNCS/App-ClusterSSH-4.13.tar.gz
  ./Build -- OK
Running Build test
t/00-load.t ....... ok
t/01l10n.t ........ ok
t/02base.t ........ ok
t/05getopts.t ..... ok
t/10host.t ........ ok
t/15config.t ...... ok
t/20helper.t ...... ok
t/30cluster.t ..... ok
t/80clusterssh.t .. Subroutine CORE::GLOBAL::exit redefined at /usr/lib64/perl5/vendor_perl/Tk.pm line 415.
t/80clusterssh.t .. ok
t/boilerplate.t ... ok
t/changes.t ....... ok
t/manifest.t ...... ok
t/perltidy.t ...... 1/27 # The file 'lib/App/ClusterSSH.pm' is not tidy
# +----+--------------------------------------------------------------------------------+--------------------------------------------------------------------------------+
# | 309|                                                                                |                                                                                |
# | 310|                     # YES! current keycode have priority over old one (phew!)  |                     # YES! current keycode have priority over old one (phew!)  |
# | 311|                        $keyboardmap{ $keycodetosym{ $keyboard[$i][$modifier]   |                        $keyboardmap{ $keycodetosym{ $keyboard[$i][$modifier]   |
# * 312|                                } }                                             |                        } }                                                     *
# | 313|                            = $keyboard_stringlike_modifiers{$modifier}         |                            = $keyboard_stringlike_modifiers{$modifier}         |
# | 314|                            . ( $i + $min );                                    |                            . ( $i + $min );                                    |
# | 315|                    }                                                           |                    }                                                           |
# +----+--------------------------------------------------------------------------------+--------------------------------------------------------------------------------+
t/perltidy.t ...... 2/27
#   Failed test ''lib/App/ClusterSSH.pm''
#   at t/perltidy.t line 13.
t/perltidy.t ...... 24/27 # Looks like you failed 1 test of 27.
t/perltidy.t ...... Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/27 subtests
t/pod-coverage.t .. ok
t/pod.t ........... ok
t/range.t ......... ok

Test Summary Report
-------------------
t/05getopts.t   (Wstat: 0 Tests: 171 Failed: 0)
  TODO passed:   160-163, 168-171
t/perltidy.t    (Wstat: 256 Tests: 27 Failed: 1)
  Failed test:  2
  Non-zero exit status: 1
Files=16, Tests=1951, 12 wallclock secs ( 0.29 usr  0.04 sys + 11.53 cusr  0.38 csys = 12.24 CPU)
Result: FAIL
Failed 1/16 test programs. 1/1951 subtests failed.
  DUNCS/App-ClusterSSH-4.13.tar.gz
  ./Build test -- NOT OK
//hint// to see the cpan-testers results for installing this module, try:
  reports DUNCS/App-ClusterSSH-4.13.tar.gz
duncs commented 6 years ago

Please confirm your versions of perltidy and test::perltidy

Duncs

TheFiZi commented 6 years ago
Perl::Tidy
-------------------------------------------------------------------------
        (no description)
        S/SH/SHANCOCK/Perl-Tidy-20180101.tar.gz
        /home/me/perl5/lib/perl5/Perl/Tidy.pm
        Installed: 20180101
        CPAN:      20180101  up to date
        Steve Hancock (SHANCOCK)
        perltidy@users.sourceforge.net

Test::PerlTidy
-------------------------------------------------------------------------
        (no description)
        L/LA/LARRYL/Test-PerlTidy-20130104.tar.gz
        /usr/local/share/perl5/Test/PerlTidy.pm
        Installed: 20130104
        CPAN:      20130104  up to date
        Larry Leszczynski (LARRYL)
        larryl@cpan.org
duncs commented 6 years ago

That is a newer version of Perl::Tidy than I used; I will upgrade to that and test it out

duncs commented 6 years ago

This issue is due to that version of Perl::Tidy - are you able to use the previous version, 20171214?

I have made some changes in the repo since this release that I do not want to make a new non-dev version for, so I need to work out how best to create a fixed release without those changes in git.

TheFiZi commented 6 years ago

Bingo. That fixed it.

cpan SHANCOCK/Perl-Tidy-20171214.tar.gz
cpan update App::ClusterSSH
tmancill commented 4 years ago

Is this still occurring since 4.13.1 was released - specifically: https://github.com/duncs/clusterssh/blob/276cab701468c461c49bcc9f8e4df5a4cd02e415/Changes#L29 ? Can this issue be closed?

TheFiZi commented 4 years ago

I can no longer test. I don't have the CentOS 7 VM anymore with X11 installed. I moved it to CentOS 8 when it came out a while back. We'll call it resolved.