Convert from file ~/.cssrch to directory ~/.clusterssh tests fails

[denydias]

Hi @duncs,

I'm trying to compile the new 4.03_02. When running the test, I get this:

# LANG=en_US.UTF-8 ./Build test
Generating: ccon
Generating: crsh
Generating: cssh
Generating: ctel
t/00-load.t ....... ok   
t/01l10n.t ........ ok   
t/02base.t ........ ok
t/05getopts.t ..... ok
t/10host.t ........ ok
t/15config.t ...... 1/?
#   Failed test 'died ok'
#   at t/15config.t line 479.
#          got: 'return'
#     expected: 'die'

#   Failed test 'Expecting no STDERR'
#   at t/15config.t line 482.
#          got: 'Moved $HOME/.csshrc to $HOME/.csshrc.DISABLED
# Created new configuration file within $HOME/.clusterssh/
# '
#     expected: ''

#   Failed test 'Expected die msg Moved $HOME/.csshrc to $HOME/.csshrc.DISABLED
# Created new configuration file within $HOME/.clusterssh/
# '
#   at t/15config.t line 483.
#          got: undef
#     expected: 'Unable to create directory $HOME/.clusterssh: Permission denied
# '
# Looks like you failed 3 tests of 155.
t/15config.t ...... Dubious, test returned 3 (wstat 768, 0x300)
Failed 3/155 subtests
t/20helper.t ...... ok
t/30cluster.t ..... ok
t/80clusterssh.t .. ok
t/boilerplate.t ... ok
t/changes.t ....... ok
t/manifest.t ...... ok
t/pod-coverage.t .. ok
t/pod.t ........... ok

Test Summary Report
-------------------
t/15config.t    (Wstat: 768 Tests: 155 Failed: 3)
  Failed tests:  142, 145-146
  Non-zero exit status: 3
Files=14, Tests=1566,  4 wallclock secs ( 0.45 usr  0.04 sys +  3.78 cusr  0.26 csys =  4.53 CPU)
Result: FAIL
Failed 1/14 test programs. 3/1566 subtests failed.

I'm running these as root, so the permission denied seems to be bogus.

[levaidaniel]

13 is the same, while having the verbose output of t/15config.t, so I didn't close that just now.

[duncs]

This looks to be because you are running the test as root, so the permissiosn check fails as root always has access (unless ACLs are set). I'll see if I can take account of that in the test.

[duncs]

Commit pushed