search

duncs / clusterssh

Cluster SSH - Cluster Admin Via SSH
https://github.com/duncs/clusterssh/wiki
902 stars 79 forks source link

Override config via cssh_* environment variables #138

Closed babs closed 1 year ago

babs commented 3 years ago

Allow runtime configuration override via environment variables

coveralls commented 3 years ago

Coverage Status

Coverage increased (+0.04%) to 54.658% when pulling 5ddb7dbe835f5f07f0c5c08a3d81e279fa52833f on babs:override_via_env into 6cbec687bdffe009a6ac1820c146527635546133 on duncs:master.

pevik commented 3 years ago

Environment variables are usually upper case. Although that might be confusing, when cssh config variables are lower case.

babs commented 3 years ago

I usually apply uppercase standard too. And I also had the same way of thought as you about confusion on case regarding config variable. Give me few minutes... :D

babs commented 3 years ago

@pevik here it is :)

pevik commented 3 years ago

You actually have mistakes in both commits, have look in my branch: https://github.com/pevik/clusterssh/commits/override_via_env.fixes

babs commented 3 years ago

You're right. Let me fix it

Next time annotate the commit it's easier to read

babs commented 3 years ago

Feature commits has been squashed.

pevik commented 3 years ago

Yep, working now :).

Reviewed-by: Petr Vorel <pvorel@suse.cz>
Tested-by: Petr Vorel <pvorel@suse.cz>