search

duncs / clusterssh

Cluster SSH - Cluster Admin Via SSH
https://github.com/duncs/clusterssh/wiki
898 stars 79 forks source link

4.02_03 'use_all_a_records' option not working #5

Closed srfraser closed 10 years ago

srfraser commented 10 years ago

the -A / use_all_a_records option is not functional in 4.02_03. Have not tested earlier versions. I suspect this is because the code starting at ClusterSSH.pm line 402 does not repopulate @tag_list with the expanded results. Adding: @tag_list = $self->cluster->get_tag($dirty); as in the following diff causes the feature to start working.

--- App-ClusterSSH-4.02_03/lib/App/ClusterSSH.pm 2014-01-31 08:34:42.000000000 +0000 +++ App-ClusterSSH-4.02_03.new/lib/App/ClusterSSH.pm 2014-05-01 11:14:45.501281229 +0100 @@ -410,6 +410,7 @@ $self->cluster->register_tag( $dirty, @alladdrs ); logmsg( 3, 'Expanded to ', $self->cluster->get_tag($dirty) );

duncs commented 10 years ago

Thanks for this report - I have patched the code and updated the repository