duncs / clusterssh

Cluster SSH - Cluster Admin Via SSH
https://github.com/duncs/clusterssh/wiki
896 stars 79 forks source link

perltidy.t started to fail #99

Closed eserte closed 6 years ago

eserte commented 6 years ago

My smoker systems show the following failure:

# The file 'lib/App/ClusterSSH.pm' is not tidy
# +-----+----------------------------------------------------------+----------------------------------------------------------+
# | 1463|        -insertborderwidth => 4,                          |        -insertborderwidth => 4,                          |
# | 1464|        -width             => 25,                         |        -width             => 25,                         |
# | 1465|        -class             => 'cssh',                     |        -class             => 'cssh',                     |
# * 1466|        )->pack(                                          |    )->pack(                                              *
# | 1467|        -fill   => "x",                                   |        -fill   => "x",                                   |
# | 1468|        -expand => 1,                                     |        -expand => 1,                                     |
# * 1469|        );                                                |    );                                                    *
# | 1470|                                                          |                                                          |
# | 1471|    $windows{history} = $windows{main_window}->Scrolled(  |    $windows{history} = $windows{main_window}->Scrolled(  |
# | 1472|        "ROText",                                         |        "ROText",                                         |
# +-----+----------------------------------------------------------+----------------------------------------------------------+

#   Failed test ''lib/App/ClusterSSH.pm''
#   at t/perltidy.t line 13.
# Looks like you failed 1 test of 27.
t/perltidy.t ...... 
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/27 subtests 

This seems to happen with the newest Perl::Tidy versions, probably because of this change: https://metacpan.org/source/SHANCOCK/Perl-Tidy-20171214/CHANGES#L3

duncs commented 6 years ago

Fix pushed to master; thanks for the report