search

dundalek / atom-markdown-mindmap

Visualize markdown files as mindmaps in Atom editor
Other
117 stars 31 forks source link

map rendered somwehat strangely #13

Closed anaderi closed 7 years ago

anaderi commented 7 years ago

(see on the right) image

Atom: 1.13.0-dev-11f8d9e Platform: Mac OS X (El capitan) v0.2.4

lyndametref commented 7 years ago

I have the same problem. Was there an atom update that broke this package?

Atom 1.12.4 Windows 7 markdown-mindmap v0.2.4

luddek commented 7 years ago

This is because of a deprecation of how markmap is getting the width and height in chrome: https://www.chromestatus.com/features/5724912467574784 I've added a pull request to markmap: https://github.com/dundalek/markmap/pull/7 If you want to change it yourself it is just two lines of code.

lyndametref commented 7 years ago

@luddek : Awesome, it fixed it perfectly for me!

chenzeyu commented 7 years ago

@luddek How can I apply your changes manually in Atom?

luddek commented 7 years ago

@chenzeyu Change line 129 and 130 in ~/.atom/packages/markdown-mindmap/node_modules/markmap/view.mindmap.js to

    state.height = svg.node().getBoundingClientRect().height;
    state.width = svg.node().getBoundingClientRect().width;
RickTorresJr commented 7 years ago

@luddek Required a restart of Atom but worked perfectly. Big thanks.

ChrisChinchilla commented 7 years ago

@dundalek How can we get this fixed? Is there a way to override in your code?

dundalek commented 7 years ago

This is now fixed and published, update to the latest version v0.2.5 inside Atom.