search

dundalek / atom-markdown-mindmap

Visualize markdown files as mindmaps in Atom editor
Other
117 stars 31 forks source link

Suggested conversion from coffeescript to ES6 #41

Open frapples opened 5 years ago

frapples commented 5 years ago

Hi: I implemented the following features in my own init.js:

  1. Filter whether automatic opening is enabled based on the file extension.
  2. When switching file windows, the preview window will also switch.
  3. When the file window is closed, the preview window will also close.

These features are inspired by atom-preview-enhanced, which I find very easy to use, so I implemented these features with reference to atom-preview-enhanced.

I want to merge these implementations into the main branch. However, this package is implemented using coffeescript, Coffeescript is now obsolete and difficult to maintain and develop. In fact, the atom official has deprecated coffeescript: https://discuss.atom.io/t/no-more-coffee-decaffeinate-the-atoms-core-atom-without-coffeescript/51092

I recommend that this package be transferred from coffeescript to ES6 for ease of maintenance and ease of development. There are already mature tools that automatically help with the conversion: https://github.com/decaffeinate/decaffeinate

This is my some suggestion. I hope you can agree with me. Or I had to fork this repository and complete the conversion myself. Thank you.

dundalek commented 5 years ago

Hi, this package initially started as a fork of the official markdown-preview which is written in coffee.

Do you have a branch with your changes available? I would like to see the changes before making a decision to switch.