search

dundalek / closh

Bash-like shell based on Clojure
Eclipse Public License 1.0
1.62k stars 66 forks source link

Fix completion by catching exceptions #99 #102

Closed jeroenvandijk closed 5 years ago

jeroenvandijk commented 5 years ago

This seem to fix completion (I get new completions now!)

Maybe you want to do it in a different style though. I don't fully grasp the flow of the process chains yet.

Btw, I have oh-my-zsh installed and normally I get completes on dirs and files, but I don't see that now. Does this indicate an issue?

dundalek commented 5 years ago

The chain-> is a wrapper that allows code sharing by using threading -> for clj and promises for cljs. Same issue might likely be present in the cljs version too, so I need to test it if this fixes it too.

For the zsh mismatch the reason might be that bash completions currently take precedence. We may probably want to switch and use bash as a last resort, since zsh users are more likely to have tuned configs.

dundalek commented 5 years ago

Cool, works with the node version too.