search

dundalek / closh

Bash-like shell based on Clojure
Eclipse Public License 1.0
1.61k stars 65 forks source link

Fix glob #164

Closed kirillsalykin closed 4 years ago

kirillsalykin commented 4 years ago

This PR fixes glob on JVM.

closes #158

@dundalek not sure I understand when cwd can be nil and why it is treated as a valid condition.

dundalek commented 4 years ago

Hi @kirillsalykin, thanks for the help. This looks cool.

The nil cwd is there because of historical reasons. I think we can make it be always explicitly passed and fix any code that uses it with incorrect single arity.

I would love if we could somehow leverage the clj-glob test suite to make sure we cover all of the other cases like brace expansion, question mark wildcards, etc.

kirillsalykin commented 4 years ago

@dundalek sci specific tests also failing on master - don't think my changes have caused it. Could you please look into it? and please review.

dundalek commented 4 years ago

Awesome work, seems to work great :rocket:

Yeah, those sci CI errors are unrelated, they are about a functionality that needs to be yet implemented.