search

dundalek / closh

Bash-like shell based on Clojure
Eclipse Public License 1.0
1.62k stars 66 forks source link

Search command history (`Ctrl-R`) #47

Open mnewt opened 6 years ago

mnewt commented 6 years ago

I think it should work like fzf. See also the fish key bindings: https://github.com/fisherman/fzf

dundalek commented 6 years ago

Can you elaborate a bit more what you mean? Would this be solved once we add support for custom key bindings (then users could bind keys to use fzf directly)?

mnewt commented 6 years ago

That's a good question. Maybe some of both?

I was thinking the basic progressive search functionality would be good to incorporate into closh. But key bindings should allow for incorporating fzf using various shortcuts just like fish.

mnewt commented 6 years ago

fzf has an interesting take on a completion mechanism that is an alternative to the more typical list that drops down from the cursor position. I think both may have their uses.

jeroenvandijk commented 5 years ago

I've used CTRL-r with the latest version (uberjar) and I think this works. At least how I expect this shortcut to work

dundalek commented 5 years ago

As I understand this probably refers to having interactive completion menus. Rebel version now shows selectable completions inline, but I think there is still a room for improvement.