Closed ramgp closed 5 months ago
Attention: Patch coverage is 71.79487%
with 11 lines
in your changes are missing coverage. Please review.
Project coverage is 89.96%. Comparing base (
58ad4d3
) to head (d7d5022
).
Files | Patch % | Lines |
---|---|---|
cmd/gdu/app/app.go | 0.00% | 3 Missing and 1 partial :warning: |
tui/tui.go | 75.00% | 3 Missing and 1 partial :warning: |
tui/show.go | 84.21% | 2 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
The ui code needs to be called inside ui.app.QueueUpdateDraw(func() {
to handle concurrency properly. See https://github.com/rivo/tview/wiki/Concurrency#actions-in-goroutines for more details.
I will add few improvements/fixes to your PR.
The user feedback is displayed in the header, I tried to make so that it disappears automatically after some time, but it seems to only update after some other action like moving in the list
Please let me know if this is good enough or if some other approach is preferred
Resolves #224.