search

dune-community / dune-xt-common

Other
2 stars 3 forks source link

[cmake/py] fix codegen cache file input + logging location #123

Closed renefritze closed 6 years ago

renefritze commented 6 years ago

This one will likely appear to break tests in dune-gdt, because now tests that should've been running will actually be running. This was likely also responsible for the sometimes weird test template behaviours @TiKeil saw in xt-functions. Basically due to my typo the correct, in-module, cmake cache was NEVER read. Instead the fallback was ALWAYS parsed. Now I wrote this stuff when gdt still depended on pdelab/fem, so this never actually made difference in practice because the fallback cache would already have alugrid for example. Now however the fallback is dune-localfunctions. Now guess which tests haven't actually been running in quite a while.

renefritze commented 6 years ago

Pinging @dune-community/dune-xt-devs before I merge so everybody hopefully sees this in case stuff goes sideways downstream after I merge :cold_sweat:

renefritze commented 6 years ago

I'll be updating CI docker now and restarting last master builds in downstream modules.