search

dune-community / dune-xt-common

Other
2 stars 3 forks source link

Dailywork ftschindler #126

Closed ftalbrecht closed 5 years ago

ftalbrecht commented 6 years ago

Please have a look at the change in configuration, @renemilk. Otherwise I 've had problems in cases where we have command line overrides but no config file. Would that break anything for you?

renefritze commented 6 years ago

Apparently I'm not smart enough to handle the review buttons correctly, sorry.

ftalbrecht commented 6 years ago

And I have no idea how to request a re-review. Please have another look at the bisection thing.

renefritze commented 6 years ago

I still think that code can return an rr s.t. condition(rr) != true maybe I can come up with a failing test.

renefritze commented 6 years ago

I think the note in the docs precludes the failure I imagined. Or I imagined it entirely :wink: Anywho, I'm pushing a simplification for the exception test, but otherwise I'm happy.

renefritze commented 6 years ago

Sorry for the merge thingy, that's the .gitsuper conflict resolution via Github UI. You can ofc throw that away if you prefer to manually rebase.

codecov[bot] commented 5 years ago

Codecov Report

Merging #126 into master will increase coverage by 0.62%. The diff coverage is n/a.

Impacted Files Coverage Δ
dune/xt/common/math.cc 66.66% <0%> (-33.34%) :arrow_down:
dune/xt/common/memory.hh 70% <0%> (-2.42%) :arrow_down:
dune/xt/common/fixed_map.hh 89.04% <0%> (-1.37%) :arrow_down:
dune/xt/common/fmatrix.hh 94.47% <0%> (-0.59%) :arrow_down:
dune/xt/common/logstreams.cc 80.45% <0%> (-0.23%) :arrow_down:
dune/xt/common/configuration.hh 67.72% <0%> (-0.05%) :arrow_down:
dune/xt/common/exceptions.hh 70% <0%> (ø) :arrow_up:
dune/xt/common/timings.cc 86.29% <0%> (ø) :arrow_up:
dune/xt/common/numeric_cast.hh 60% <0%> (ø) :arrow_up:
dune/xt/common/math.hh 100% <0%> (ø) :arrow_up:
... and 21 more