search

dune-community / dune-xt-common

Other
2 stars 3 forks source link

Refactor convergence study #137

Closed ftalbrecht closed 6 years ago

ftalbrecht commented 6 years ago

This pr refactors the convergence study to match the new dune-gdt. I do not think that we use it anywhere else, but merging this pr will break the old dune-gdt tests, so perhaps we postpone this a bit ...

ftalbrecht commented 6 years ago

Yeah, this is bothering me for quite some time now, and I could not really decide. So you prefer to leave out the else if there is a return in the if? I think I could live well with that...

tobiasleibner commented 6 years ago

+1 for leaving out the else.

tobiasleibner commented 6 years ago

If this breaks the old dune-gdt, we can just wait until we switched to the new-master. Depends on: #135 .

codecov[bot] commented 6 years ago

Codecov Report

Merging #137 into master will increase coverage by 1.18%. The diff coverage is 85.71%.

Impacted Files Coverage Δ
dune/xt/common/float_cmp.hh 100% <ø> (ø) :arrow_up:
dune/xt/common/type_traits.hh 50% <ø> (+1.16%) :arrow_up:
dune/xt/common/string.hh 100% <100%> (ø) :arrow_up:
dune/xt/common/configuration.cc 46.22% <100%> (+0.24%) :arrow_up:
dune/xt/common/exceptions.hh 70% <100%> (+10%) :arrow_up:
dune/xt/common/string_internal.hh 77.84% <50%> (-0.05%) :arrow_down:
dune/xt/common/bisect.hh 91.66% <91.66%> (ø)
dune/xt/common/validation.hh 88.74% <0%> (-0.47%) :arrow_down:
... and 4 more
renefritze commented 6 years ago

Reminder: fixing that conflict can [skip ci]