search

dune-community / dune-xt-common

Other
2 stars 3 forks source link

Switch to 2.6 Core modules? #143

Closed tobiasleibner closed 5 years ago

tobiasleibner commented 5 years ago

As we are changing to the new-master branches currently and are not backwards compatible anyway, we could also switch from releases/2.5 to releases/2.6. I created branches compatible_with_2.6 in all xt modules, dune-xt-super and dune-pybindxi. Locally, all tests are passing for me.

The main changes we have to do are related to the python changes (the functionality from the old dune-python moved to dune-common). Other than that, there are only minor changes.

It probably would be possible to support both 2.5 and 2.6, but it might be annoying to get the cmake python stuff right. So I would suggest dropping support for 2.5 and requiring 2.6. Any opinions?

renefritze commented 5 years ago

I'm very happy that the necessary changes seem minor, I feared a lot worse. If the test (generation) in dune-gdt also works I'm very pro dropping 2.5 compatibility going forward. It's indeed a very opportune moment for it too.

ftalbrecht commented 5 years ago

Done by now