search

dune-community / dune-xt-common

Other
2 stars 3 forks source link

fix ambigous std::abs overloads #157

Closed ftalbrecht closed 5 years ago

codecov[bot] commented 5 years ago

Codecov Report

Merging #157 into master will increase coverage by <.01%. The diff coverage is 60%.

Impacted Files Coverage Δ
dune/xt/common/math.hh 100% <ø> (ø) :arrow_up:
dune/xt/common/math.cc 100% <ø> (+33.33%) :arrow_up:
dune/xt/common/fix-ambiguous-std-math-overloads.cc 60% <60%> (ø)
codecov[bot] commented 5 years ago

Codecov Report

Merging #157 into master will increase coverage by <.01%. The diff coverage is 60%.

Impacted Files Coverage Δ
dune/xt/common/math.hh 100% <ø> (ø) :arrow_up:
dune/xt/common/math.cc 100% <ø> (+33.33%) :arrow_up:
dune/xt/common/fix-ambiguous-std-math-overloads.cc 60% <60%> (ø)
ftalbrecht commented 5 years ago

any objections against merging, @renefritze?

renefritze commented 5 years ago

Sorry, apparently I forgot to submit my review form a couple of days back.

ftalbrecht commented 5 years ago

Applied the changes you proposed