search

dune-community / dune-xt-common

Other
2 stars 3 forks source link

Fix install of python package #158

Closed ftalbrecht closed 5 years ago

ftalbrecht commented 5 years ago

This requires https://github.com/dune-community/dune-pybindxi/pull/7

ftalbrecht commented 5 years ago

Just restarting the travis builds does not make them pass (I was hoping the docker images would contain the updated dune-pybindxi by now). Any ideas, @renefritze?

renefritze commented 5 years ago

DId you bump the pybind module in the super module?

ftalbrecht commented 5 years ago

On Mon, 2019-01-07 at 23:52 -0800, René Fritze wrote:

DId you bump the pybind module in the super module?

What, this is not happening automatically? :)

Thx for the hint, I'll try again...

renefritze commented 5 years ago

https://github.com/dune-community/dune-pybindxi/pull/7#issuecomment-447494536 wrote:

You need to merge this PR and/or update the ref in the super module before your downstream PRs can begin to succeed. Otherwise the docker images still have the old version of this module.

I guess technically you followed that :wink: