search

dune-community / dune-xt-common

Other
2 stars 3 forks source link

Fix FixedMap test #32

Closed tobiasleibner closed 4 years ago

tobiasleibner commented 7 years ago

The line

  EXPECT_DEATH(*too_big.end(), ".*");

fails sometimes for me, as the dereferencing of the end iterator is not guaranteed to cause a Segfault (or something similar) everytime. I am not sure whether the FixedMap is meant to check the iterator position before dereferencing, then we should add the check. Otherwise we should change the test.

renefritze commented 7 years ago

Do you happen to be remember which compiler/stl setup doesn't die there?

tobiasleibner commented 7 years ago

If I remember correctly it was the standard gcc setup on stinson or jaina with the gcc-debug config-opts.

tobiasleibner commented 7 years ago

I tried to reproduce but now the test works for me both with release and debug settings. So I am not sure in which setup the test failed. But what the test actually does is an out-of-bounds access to an array, which is not guaranteed to fail.

tobiasleibner commented 4 years ago

The relevant line is commented out in the test at the moment, we may as well remove it. So closing this issue.