search

dune-community / dune-xt-common

Other
2 stars 3 forks source link

Fix TimingData #90

Closed tobiasleibner closed 4 years ago

tobiasleibner commented 6 years ago

TimingData currently uses UnsafePerThreadValue, which is the old implementation of PerThreadValue that suffers from occasional segfaults due to the actual number of threads being higher than ThreadManager::max_threads(). See PR https://github.com/dune-community/dune-xt-common/pull/89 for details. Unfortunately, the new implementation of PerThreadValue initalizes the data in each thread lazily, which is not compatible with the current implemenation of TimingData. We need to either change TimingData to work with the new PerThreadValue or without PerThreadValue at all, or we need to find a way to fix the old PerThreadValue implementation.

tobiasleibner commented 4 years ago

Moved to dune-xt, closing here.