search

dune-community / dune-xt-common

Other
2 stars 3 forks source link

dailywork-ftschindler #97

Closed ftalbrecht closed 6 years ago

ftalbrecht commented 6 years ago

I found these changes lying around somewhere. In particular, this includes an update of how the Configuration parses the command line, that we talked about ages ago, @renemilk, and that I still preferr.

ftalbrecht commented 6 years ago

The main change I am interested in is towards named options, and I recall that we both agreed that this would be a good thing. Would you still agree? Regarding failure on argc < 2: I would be willing to go back to the old behaviour, maybe with an optional switch which defaults to the old behaviour.

ftalbrecht commented 6 years ago

To be clear: I would like to have the syntactic sugar as in https://github.com/dune-community/dune-xt-common/pull/97/commits/2a2a2e384f64a09f9a1f2e14dfeabbf26971823e, which would make our programs behave much more like other unix programs...

renefritze commented 6 years ago

Yes, please revert to the old behaviour, if I don't actively select the new one. Thanks.

I don't recall talking about this, but yeah, named options are good. But haven't I've been using them already is what I'm asking: https://github.com/wwu-numerik/dune-multiscale-experiments/blob/master/speedup/supermuc/phase2.pure.tpl#L35

ftalbrecht commented 6 years ago

Yes, mostly. But the old readOptions uses a single dash while the new readNamedOptions uses double dashes...

We should now have the old behaviour (failure if the command line is empty) back...

renefritze commented 6 years ago

So what's the reason to implement that change then?

ftalbrecht commented 6 years ago

I mainly wanted to have --named=options instead of -named=options^^

renefritze commented 6 years ago

:roll_eyes:

Is using a single dash now an error? If I have to change my scripts because you want two dashes I'll have to roll my eyes even harder at you.

TiKeil commented 6 years ago

I just started to compile and run my tests on this state and no test is working anymore (runtime error). This is probably not supposed to be like that, is it?

terminate called after throwing an instance of 'Dune::XT::Common::Exceptions::configuration_error' what(): Exceptions::configuration_error [read_command_line|/home/tikeil/dune-gdt-LOD/dune-xt-common/dune/xt/common/configuration.cc:244] => when trying to read from the command line (see below).

renefritze commented 6 years ago

I guess that means yes :wink: