search

duneanalytics / dune-client

A framework for interacting with Dune Analytics' officially supported API service
Apache License 2.0
85 stars 22 forks source link

Add `delete` table endpoint to sdk #119

Closed waddahAldrobi closed 6 months ago

waddahAldrobi commented 6 months ago

In this PR, we add support for the new table endpoints in the SDK:

We also add a _delete function to the BaseDuneClient

waddahAldrobi commented 6 months ago

@bh2smith ugh, I forgot to squash merge again... Isn't there a way to make that the default behaviour?

bh2smith commented 6 months ago

Isn't there a way to make that the default behaviour?

After you do it once, GitHub will use this default choice.

waddahAldrobi commented 6 months ago

Isn't there a way to make that the default behaviour?

After you do it once, GitHub will use this default choice.

Right, I was thinking of this though to enforce it https://github.com/dotnet/runtime/issues/260#issuecomment-558455365