Closed gosuto-inzasheru closed 1 year ago
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅
I have read the CLA Document and I hereby sign the CLA
im a bit out of depth here.
in the basic client, the requests
' response is converted to a binary stream using BytesIO
:
return ExecutionResultCSV(data=BytesIO(response.content))
however, the asyncio
variant of our session returns a StreamReader
type response. although a stream, it cannot be handled by pandas
' read_csv
. currently i was able to solve this as such:
return ExecutionResultCSV(data=BytesIO(await response.content.read(-1)))
but is this really the most efficient way to convert the asynchronous response to something pandas can read?
client.py
versus client_async.py
: https://www.diffchecker.com/tXrNtPqY/
I would be willing to merge as is and we can tag a new release after a few other of the pending/incoming PRs are landed. Just let me know
@eliseygusev care to comment on the async aspect here maybe?
i will resolve conflicts and update for updates made to client in #53
Were you still planning on resolving conflicts here?
yes will do, just also have a day job :(
should be good to merge @bh2smith!
performance
param as introduced in #53 client.py
and client_aync.py
: https://www.diffchecker.com/ej06mO8H/@bh2smith what is in the way of merging this? i think waiting will just creates more conflicts down the road for other prs...
Ya we can merge this... but the performance tier is still failing. Its fine though (aw you explained)
Could you also review #59 --- @gosuto-inzasheru? Then I can tag a new release.
opening this as a draft to get some feedback.
get_result_csv
,_refresh
,refresh_csv
andrefresh_into_dataframe
client.py
andclient_async.py
, to make future maintenance easiermake test-all
passes 100%closes #54