search

duneanalytics / dune-client

A framework for interacting with Dune Analytics' officially supported API service
Apache License 2.0
85 stars 22 forks source link

[Bug] Parameters Ignored. #6

Closed bh2smith closed 2 years ago

bh2smith commented 2 years ago

It seems the parameters passed with the query are being ignored. This attempts to fix the issue, but the test still demonstrates that the fix doesn't yet work.

josojo commented 2 years ago

Hm... not sure whether I should approve or ask you to look further for the bug. ;)

bh2smith commented 2 years ago

Great questions @josojo - This isn't meant to be merged (I should have made it a draft). I created this to demonstrate to Dune the isolated problem (this PR has been shared with them).

Did you connect to dune to ask about it?

I have reached out to Dune (awaiting reply)

Did you try to send the post request via curl and did it then work?

I have not yet tried with cURL (will do so)

One other guess I have is that they only support parameters for Dune Engine V2 queries. Will also be trying this.

bh2smith commented 2 years ago

Fixed it! Silly me the keyword in request.post use json= instead of params=!