search

duneanalytics / spellbook

SQL views for Dune
Other
1.11k stars 1.02k forks source link

Solana dex trades: enrichment + base trades setup #6245

Closed 0xRobin closed 1 week ago

0xRobin commented 1 week ago

Solana dex trades: enrichment + base trades setup.

This PR moves the following columns from the base (project) models to the enriched model.

token_bought_symbol
token_sold_symbol
token_pair
token_bought_amount
token_sold_amount
amount_usd
fee_usd
andrewhong5297 commented 1 week ago

pls keep me in the loop as you work on these! I have a bunch of PRs I need to make to migrate and add a few columns to dex solana first. might be worth you waiting until I'm done there.

0xRobin commented 1 week ago

@andrewhong5297 thanks for notifying, currently only this one right: https://github.com/duneanalytics/spellbook/pull/6244?

Seems like it shouldn't impact this PR, but will wait with the followup PR (that'll remove these columns from the marketplace models itself)

jeff-dude commented 1 week ago

reiterating before merge, this won't impact project level spells yet. rob will be following up with more PRs to clean up project level that feed into this. there will then be final project level views which replicate the current state today, so no queries will break.