Fix Bebop duplicates bug

duneanalytics / spellbook

SQL views for Dune

Other

1.16k stars 1.09k forks source link

Fix Bebop duplicates bug #6265

Closed B1boid closed 3 months ago

B1boid commented 3 months ago

Looks like some kind of weird inconsistent behavior of UNION ALL, because tests were passed successfully, but then in prod a couple of old duplicates appeared.

I think I fixed it, so returning eth model back to prod (https://github.com/duneanalytics/spellbook/pull/6257#issue-2373672651)

dune-eng commented 3 months ago

Workflow run id 9678965050 approved.

dune-eng commented 3 months ago

Workflow run id 9678965438 approved.

dune-eng commented 3 months ago

Workflow run id 9678965447 approved.

dune-eng commented 3 months ago

Workflow run id 9679064294 approved.

dune-eng commented 3 months ago

Workflow run id 9679064139 approved.

dune-eng commented 3 months ago

Workflow run id 9679064296 approved.

github-actions[bot] commented 3 months ago

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

1 out of 2 committers have signed the CLA.
:white_check_mark: @B1boid
:x: @alex-vorobev
_{You can retrigger this bot by commenting recheck in this Pull Request}

dune-eng commented 3 months ago

Workflow run id 9680498754 approved.

dune-eng commented 3 months ago

Workflow run id 9680498981 approved.

dune-eng commented 3 months ago

Workflow run id 9680498960 approved.