search

duneanalytics / spellbook

SQL views for Dune
Other
1.11k stars 1.02k forks source link

Phoenix dex fix #6281

Open andrewhong5297 opened 6 days ago

andrewhong5297 commented 6 days ago

redo phoenix fix without seed

andrewhong5297 commented 5 days ago

Looks good to merge when CI passes ✔️ I've made a couple small adjustments that should also be replicated once we remove columns from other base spells.

  1. rename the model to _base_trades
  2. add the check_columns_solana_dex_trades schema test
  3. add a compatibility view at the old model name, @aalan3 notified me these solana dex models do see some usage on the base level so we try and not break those user queries.

good callouts and foresight! I'll copy the same pattern for meteora/goose when I get to it later today/tomorrow