Assignment 2 Review

[avo1]

:+1: Nice work. The primary challenge of this homework was to learn how to use UITableView to manage a complex form, establish communication between view controllers, and apply the correct Auto Layout constraints.

This was a challenging assignment, congrats on completing it successfully!

Grading Summary:

• Functionality: Good
• Code Style: Excellent
• Visual Design: Excellent

  Overall: Good

  Detailed Notes

• Nice work specifying the Auto Layout constraints. You really pay attention to the detail (you have the placeholder for the image, you showed "No result" instead of empty table...)
• Nice work linking the filter model with the controls. All cells in FilterVC are dequeued correctly. See this popular form library for an alternative to implementing forms manually. Just minor thing, if your notice, the icons you use is broken because you are running on retina display, then you need to drag your icons into @2x on images.xcassets. Read more about it here

• Nice work connecting the view controllers via the custom filter delegate. This is a popular pattern for handling events between view controllers.

You can spend some time implement the optional. Those are some good practices we can see in any app.

[dunghuynh1990]

@avo1 Thanks for taking time to review my app. I will do the improvement soon and notify you to review again 👍