dunghuynh1990 / Swift-Assignment-3--Twitter

0 stars 0 forks source link

[Assignment 3] Review #1

Open thanhtan1105 opened 8 years ago

thanhtan1105 commented 8 years ago

:+1: nice work. The point of this homework was to explore a simple example of a full MVC application with a RESTful API.

Grading Summary

Functionality: Average
Code Style: Good
Visual Design:Average
Overall: Average
Detailed Notes
Nice work specifying the Auto Layout constraints.
It'd be better if you disable the Tweet button in NewTweetViewController or show the error when the tweet length is larger than 140.
Unfortunately, when I am trying get more tweet, application is crash. Let check it again

screenshot 2016-08-16 19 26 00

Nice for handling post new tweet. But you can make it better when successfully post, the new tweet can automatically show on UITableView.

dunghuynh1990 commented 8 years ago

Hi @thanhtan1105 : I got a bug when post a new status and back to home, the new status not appearin home.