search

dunglas / DunglasActionBundle

Symfony controllers, redesigned
https://dunglas.fr/2016/01/dunglasactionbundle-symfony-controllers-redesigned/
MIT License
256 stars 14 forks source link

Remove the ability to auto-discover across *all* bundles #28

Closed weaverryan closed 8 years ago

weaverryan commented 8 years ago

The current autodiscover configuration will look at directories across all bundles. I don't understand the point of this: third-party bundles should never use autowiring anyways.

I think we should remove this and keep only the directories key. This would allow the bundle to (potentially) be more opinionated anyways - for example in #27 - I was wondering if this was originally written because some core bundles have extra stuff in Command, and this was a workaround. If you don't auto-discover all bundles, you can register this stuff as services.

dunglas commented 8 years ago

Done in #26. Perfectly make sense and remove a lot of problems due do the bundle scanning third-party bundles.