search

dunglas / DunglasActionBundle

Symfony controllers, redesigned
https://dunglas.fr/2016/01/dunglasactionbundle-symfony-controllers-redesigned/
MIT License
256 stars 14 forks source link

Add support for Twig extensions #66

Closed dunglas closed 7 years ago

dunglas commented 7 years ago

WDYT of this @GuilhemN?

GuilhemN commented 7 years ago

LGTM on the principle, i'm just a bit affraid about BC: Does twig allow several registration of the same extension ? If not, this may conflict in an existing application in case those extensions are registered under a different service id. Having https://github.com/symfony/symfony/pull/20940 would be great to solve this kind of problems.

dunglas commented 7 years ago

I don't know, but it's still possible to disable this behavior by removing the Twig directory from the list of watched dirs.

theofidry commented 7 years ago

This is indeed a BC break. Not a big one IMO and as the package is not stable it's ok, but it should be at least mentioned in an UPGRADE.md

dunglas commented 7 years ago

UPGRADE file added.

theofidry commented 7 years ago

👍