dunglas / DunglasActionBundle

Symfony controllers, redesigned
https://dunglas.fr/2016/01/dunglasactionbundle-symfony-controllers-redesigned/
MIT License
256 stars 14 forks source link

Updated services configuration exemple #68

Closed mickaelandrieu closed 7 years ago

mickaelandrieu commented 7 years ago

Symfony 3.3 introduced an easier way to declare service => http://symfony.com/blog/new-in-symfony-3-3-optional-class-for-named-services

fabpot commented 7 years ago

What about removing all classes then? Why just one of them?

GuilhemN commented 7 years ago

@fabpot i think that's for those using sf < 3.3

dunglas commented 7 years ago

I agree with @fabpot, we should remove all class in existing examples and add a new one with class set for people using Symfony < 3.3.

mickaelandrieu commented 7 years ago

All comments adressed, thank you :)

GuilhemN commented 7 years ago

:+1:

dunglas commented 7 years ago

Thanks @mickaelandrieu