dunglas / demo-vulcain-api-platform

Use API Platform with the Vulcain protocol and Varnish!
MIT License
35 stars 2 forks source link

dev-tls in prod? #3

Open abeal-hottomali opened 4 years ago

abeal-hottomali commented 4 years ago

Good afternoon @dunglas , hope you are well.

Was looking to this as the basis for the containers I'd need for an actual production deployment (if a better resource currently exists, I'd like to know - the docs don't appear to mention what to do with mercure or vulcain, but that's a separate issue).

The docker-compose.prod.yml file appears to be running the dev-tls service. That's not meant to be part of prod, is it? Was that to make the demo work?

dunglas commented 4 years ago

Actually « prod » here just means « with all optimization enabled » (aka uses the Symfony prod env). It’s not intended to be used in production, and is not secure at all.