Closed TamasSzigeti closed 1 year ago
@dunglas Please have a look
bump @dunglas What do you think of this approach?
I personally often change class namespaces to better organize code, leading to thorny migrations, so that change would be very welcome!
I +1 👍
@dunglas Addressed change reqs, added tests and notes in readme.
@dunglas Also fixed some unrelated issues to make CI green
@dunglas any chance to see this merge soon ? Can I help with something ?
@TamasSzigeti Do you want to make the modification proposed by @dunglas ? If you don't have time, i can do it !
Let me know 🙂
Thanks for the review, Kévin!
@amenophis Thanks for the offer, go ahead if you wish, otherwise I can take care of it this weekend.
Hi @TamasSzigeti,
Seems you did not had time to push update. Could you give me permissions to push on your fork and will try to fix last comments ?
Thanks
@dunglas Comments addressed
@amenophis Thanks, just did it (:
Really nice feature :+1:
@dunglas Comments addressed plus I fixed the workflow again:
Might be worth dropping unsupported php and symfony versions in another PR
Thank you very much for your hard work @TamasSzigeti!!
Introduce bundle config to map keys to class names
See https://github.com/dunglas/doctrine-json-odm/issues/63
Allow custom type aliases from bundle config or custom implementation.
Fix unrelated errors to make CI green:
class_exists(BackedEnum::class)
always returns false