dunglas / doctrine-json-odm

An object document mapper for Doctrine ORM using JSON types of modern RDBMS.
https://dunglas.fr
MIT License
586 stars 66 forks source link

Allow using type names in place of class names #118

Closed TamasSzigeti closed 1 year ago

TamasSzigeti commented 2 years ago

Introduce bundle config to map keys to class names

See https://github.com/dunglas/doctrine-json-odm/issues/63

Allow custom type aliases from bundle config or custom implementation.

Fix unrelated errors to make CI green:

TamasSzigeti commented 2 years ago

@dunglas Please have a look

TamasSzigeti commented 2 years ago

bump @dunglas What do you think of this approach?

bpolaszek commented 2 years ago

I personally often change class namespaces to better organize code, leading to thorny migrations, so that change would be very welcome!

I +1 👍

TamasSzigeti commented 2 years ago

@dunglas Addressed change reqs, added tests and notes in readme.

TamasSzigeti commented 2 years ago

@dunglas Also fixed some unrelated issues to make CI green

amenophis commented 1 year ago

@dunglas any chance to see this merge soon ? Can I help with something ?

amenophis commented 1 year ago

@TamasSzigeti Do you want to make the modification proposed by @dunglas ? If you don't have time, i can do it !

Let me know 🙂

TamasSzigeti commented 1 year ago

Thanks for the review, Kévin!

@amenophis Thanks for the offer, go ahead if you wish, otherwise I can take care of it this weekend.

amenophis commented 1 year ago

Hi @TamasSzigeti,

Seems you did not had time to push update. Could you give me permissions to push on your fork and will try to fix last comments ?

Thanks

TamasSzigeti commented 1 year ago

@dunglas Comments addressed

@amenophis Thanks, just did it (:

Guite commented 1 year ago

Really nice feature :+1:

TamasSzigeti commented 1 year ago

@dunglas Comments addressed plus I fixed the workflow again:

Might be worth dropping unsupported php and symfony versions in another PR

dunglas commented 1 year ago

Thank you very much for your hard work @TamasSzigeti!!