search

dunglas / mercure

🪽 An open, easy, fast, reliable and battery-efficient solution for real-time communications
https://mercure.rocks
GNU Affero General Public License v3.0
3.98k stars 296 forks source link

Helm lint check CI workflow doesn't seem to be working #528

Closed sagikazarmark closed 3 years ago

sagikazarmark commented 3 years ago

The latest master build is currently broken, because the chart version was not increased in #527.

After looking at the commits in #527 it looks like the chart linter check never ran. (It would have complained about the missing chart version increase)

As a result, the latest chart fix was never released.

I can't tell whether it's intentional though, because the chart version seems to match the application version at the moment.

dunglas commented 3 years ago

Yes it's intentional. I wanted the chart to be released at the same time as the hub. But it's maybe a bad idea.

sagikazarmark commented 3 years ago

Well, a chart release would be nice because a recent patch fixes a problem that currently makes mercure installation fail on most clusters where the default storage class is non-existent or doesn't work.

sagikazarmark commented 3 years ago

Any plans to release a patch version with the latest chart fix? Currently it cannot be installed with custom storage classes.

dunglas commented 3 years ago

Yes I plan to do a release at the end of the week.

sagikazarmark commented 3 years ago

Cool, thanks

dunglas commented 3 years ago

done!

dunglas commented 3 years ago

Reopening: the chart release doesn't seem to work.

dunglas commented 3 years ago

Fixed!