search

dunglas / mercure

🪽 An open, easy, fast, reliable and battery-efficient solution for real-time communications
https://mercure.rocks
GNU Affero General Public License v3.0
3.83k stars 278 forks source link

helm - invalid pvc template for storageClass #893

Open VincentDugard opened 2 months ago

VincentDugard commented 2 months ago

hello,

When setting storageClass in helm values, I get this error

Error: UPGRADE FAILED: failed to create resource: PersistentVolumeClaim in version "v1" cannot be handled as a PersistentVolumeClaim: quantities must match the regular expression '^([+-]?[0-9.]+)([eEinumkKMGTP]*[-+]?[0-9]*)$'

the reason is that the generated yaml is 

resources:
  requests:
    storage: "1Gi"
    storageClassName: "ssd"

but it should be

resources:
  requests:
    storage: "1Gi"
storageClassName: "ssd"

cf : https://kubernetes.io/docs/concepts/storage/persistent-volumes/#persistentvolumeclaims

VincentDugard commented 2 months ago

I made a PR that should fix the issue : https://github.com/dunglas/mercure/pull/894