helm - Invalid deployment config if existingSecret is specified

dunglas / mercure

🪽 An open, easy, fast, reliable and battery-efficient solution for real-time communications

https://mercure.rocks

GNU Affero General Public License v3.0

3.98k stars 297 forks source link

helm - Invalid deployment config if existingSecret is specified #952

Open Fabccc opened 2 months ago

Fabccc commented 2 months ago

Issue

While using an existingSecret as configuration AND supplying a different name than mercure.fullName, "GLOBAL_OPTIONS" and "CADDY_EXTRA_CONFIG" both uses a non-existing secret (called mercure.fullName).

Workaround

Name the existingSecret with the same name in mercure.fullName or mercure.fullNameOverride

Lasting solution

Make "GLOBAL_OPTIONS" and "CADDY_EXTRA_CONFIG" reference the mercure.secretName instead of mercure.fullName.

dunglas commented 2 months ago

It's likely a problem introduced in https://github.com/dunglas/mercure/pull/809. Maybe @Julian-Louis as an idea of what's going on?