dungnguyensarasota / training

0 stars 0 forks source link

Plot capabilities #2

Open cfraces opened 3 years ago

cfraces commented 3 years ago

Create plot() method in Economics class

dungnguyensarasota commented 3 years ago

Dear @cfraces please review the code in feature-oop

cfraces commented 3 years ago

Forgot to run test. Regression on instantiation of Economics(**params) Make "present_value, profitability, irr, payout, dpi, cash, cash_cum, revenue, income, cost" the attributes of the Economic object (initialize with None values) API should look like:

econ = Economics() econ.calculate(**param) print(econ.npv) ... 457740.57

cfraces commented 3 years ago

Remove compute() method from plot(). Can apply plot() to econ after running calculation() Add proper error handling (try: except) in plot if attributes are empty Add validate() method to Economics() to test that project_length matches production_arr size (You can do this after vectorization)

cfraces commented 3 years ago

@dungnguyensarasota check comments on issue #2

dungnguyensarasota commented 3 years ago

Dear @cfraces Please review the changes I made

cfraces commented 3 years ago

@dungnguyensarasota please add a distribution plot for input and output.

dungnguyensarasota commented 3 years ago

Dear @cfraces I've created plot_scenario method which plot both input and output distribution Please review

cfraces commented 3 years ago

@dungnguyensarasota please return a handle for the plot instead of showing. Add an argument to the methods plot(show=False) if True only show Add comments to the methods