search

dunkmann00 / Drive-Backup

A simple way to backup your Google Drive locally.
http://www.georgeh2os.com/Drive-Backup/
Other
18 stars 4 forks source link

Fix download pattern #16

Closed dunkmann00 closed 2 weeks ago

dunkmann00 commented 1 month ago

I think I may need to use + instead to not match everything.

dunkmann00 commented 2 weeks ago

Went with a different approach. Couldn't get the pattern right for the download action, so just download everything and use the files filter on the release action to find what I want. This seems to work fine and I don't even think it is that fragile of an approach.

There was another problem with this, and it is in how the name is created. So when the build workflow creates the archive name, it now will not include the short sha for both releases and workflow dispatch triggers.

One last thing to note is that when triggering the release from workflow dispatch, it really should be run from the original tag (of course doing that means this code won't actually exist until the next release is made...which seems like a potentially big limitation). To make this work without doing that would take more work than I think is beneficial. At this point I'm not even 100% sure I'll ever need the option to trigger the release manually as long as the pattern matching of the filenames is correct. But I'll leave the functionality there for now and if it seems like it is not at all useful, remove it in the future.