search

dunkmann00 / primer

Primer is a Jekyll theme for GitHub Pages
http://www.georgeh2os.com/primer/
MIT License
3 stars 0 forks source link

Build Failing and Dark Mode #27

Open chinmayjk97 opened 1 month ago

chinmayjk97 commented 1 month ago

I shifted to your theme majorly for dark theme, however it is not working :(

I have enabled theme: dark in _config.yaml and also tried creating placeholder style.scss or even default.html. None of these helped me.

Also readme says v0.12.0 however tried with latest is v0.15.0

Builds for reference:

I'm getting build error:

Logging at level: debug Configuration file: /github/workspace/./_config.yml GitHub Pages: github-pages v231 GitHub Pages: jekyll v3.9.5 Theme: jekyll-theme-primer Theme source: /usr/local/bundle/gems/jekyll-theme-primer-0.6.0 Requiring: jekyll-github-metadata Requiring: jekyll-seo-tag Requiring: jekyll-remote-theme Requiring: jekyll-coffeescript Requiring: jekyll-commonmark-ghpages Requiring: jekyll-gist Requiring: jekyll-github-metadata Requiring: jekyll-paginate Requiring: jekyll-relative-links Requiring: jekyll-optional-front-matter Requiring: jekyll-readme-index Requiring: jekyll-default-layout Requiring: jekyll-titles-from-headings Requiring: jekyll-remote-theme GitHub Metadata: Initializing... Source: /github/workspace/. Destination: /github/workspace/./_site Incremental build: disabled. Enable with --incremental Generating... Theme: dunkmann00/primer@v0.12.0 Theme source: /tmp/jekyll-remote-theme-20240727-7-1vg66iq Remote Theme: Using theme dunkmann00/primer Remote Theme: Downloading https://codeload.github.com/dunkmann00/primer/zip/v0.12.0 to /tmp/jekyll-remote-theme-20240727-7-1t45tuk.zip Remote Theme: Unzipping /tmp/jekyll-remote-theme-20240727-7-1t45tuk.zip to /tmp/jekyll-remote-theme-20240727-7-1vg66iq Theme: Ignoring assets/css/style.scss in theme due to existing file with that path in site. Generating: JekyllOptionalFrontMatter::Generator finished in 0.000135403 seconds. Generating: JekyllReadmeIndex::Generator finished in 4.1839e-05 seconds. Generating: Jekyll::Paginate::Pagination finished in 4.509e-06 seconds. Generating: JekyllRelativeLinks::Generator finished in 0.000949135 seconds. Generating: JekyllDefaultLayout::Generator finished in 0.001781222 seconds. Generating: JekyllTitlesFromHeadings::Generator finished in 0.000502219 seconds. Rendering: assets/css/style.scss Pre-Render Hooks: assets/css/style.scss Rendering Markup: assets/css/style.scss github-pages 231 | Error: File to import not found or unreadable: @primer/view-components/app/components/primer/alpha/layout. Load paths: /usr/local/bundle/gems/jekyll-theme-primer-0.6.0/_sass /tmp/jekyll-remote-theme-20240727-7-1vg66iq/_sass /usr/local/bundle/gems/jekyll-theme-primer-0.6.0/_sass /tmp/jekyll-remote-theme-20240727-7-1vg66iq/_sass /usr/local/bundle/gems/jekyll-theme-primer-0.6.0/_sass /tmp/jekyll-remote-theme-20240727-7-1vg66iq/_sass /usr/local/bundle/gems/jekyll-theme-primer-0.6.0/_sass /tmp/jekyll-remote-theme-20240727-7-1vg66iq/_sass on line 1 Remote Theme: Cleaning up /tmp/jekyll-remote-theme-20240727-7-1vg66iq

dunkmann00 commented 1 day ago

Hi @chinmayjk97, I'm sorry for taking so long to respond to you. I didn't realize that I did not have all notifications on for this repo so I'm just seeing this now.

I am not sure why you were seeing that error. It may have something to do with the way GitHub Pages (the version you are using, i.e. Deploy from a branch) is setup. The original primer theme is automatically loaded so there may have been an issue with conflicting versions and everything getting mixed together.

It seems you decided to just use the original primer theme. If you still are interested in trying to get this to work I would recommend considering using the GitHub Actions version of GitHub Pages. There is info how to get this setup on GitHub's docs.

I also have a GitHub Action that you can use to easily get all of this working with basically a copy paste. The repo for that action is dunkmann00//jekyll-v4-gh-pages. If you use this you can remove the plugins entry and remote-theme entry from your _config.yml file since the default theme is my primer fork.

If you do decide to give this a try and have any issues, please let me know. Once again, I'm sorry it took so long to respond!